Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kms per profile & bdd for eddsa-rdfc-2022 #1766

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Sep 30, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (349bff4) to head (a39f2eb).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kms/arieskms.go 86.66% 1 Missing and 1 partial ⚠️
pkg/kms/aws/service.go 0.00% 2 Missing ⚠️
pkg/kms/registry.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
+ Coverage   86.24%   86.30%   +0.06%     
==========================================
  Files         190      191       +1     
  Lines       13419    13554     +135     
==========================================
+ Hits        11573    11698     +125     
  Misses       1345     1345              
- Partials      501      511      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skynet2 skynet2 marked this pull request as ready for review September 30, 2024 14:25
pkg/kms/arieskms.go Outdated Show resolved Hide resolved
@fqutishat fqutishat merged commit 41cf070 into trustbloc:main Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants