Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Propagate tracing info from wallet-cli #1788

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Nov 1, 2024

Open Telemetry headers are sent from the wallet-cli to the back-end server. Also, an X-Correlation-Id header is sent. When the server receives a correlation ID, it saves the ID as a span attribute.

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (ad33110) to head (492cbd0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vc-rest/startcmd/params.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files         191      191              
  Lines       17169    17170       +1     
==========================================
+ Hits        14636    14640       +4     
+ Misses       2019     2017       -2     
+ Partials      514      513       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bob Stasyszyn <bob.stasyszyn@gendigital.com>
@fqutishat fqutishat merged commit 926f929 into trustbloc:main Nov 1, 2024
9 of 10 checks passed
@bstasyszyn bstasyszyn deleted the correlation-id branch November 1, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants