Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamic wellknown #1792

Merged
merged 8 commits into from
Nov 6, 2024
Merged

feat: support dynamic wellknown #1792

merged 8 commits into from
Nov 6, 2024

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Nov 6, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2024
@skynet2 skynet2 marked this pull request as ready for review November 6, 2024 18:02
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 77.39130% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (ad33110) to head (58bb02a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...storage/redis/dynamicwellknown/dynamicwellknown.go 71.05% 9 Missing and 2 partials ⚠️
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go 76.00% 4 Missing and 2 partials ⚠️
...kg/service/wellknown/provider/wellknown_service.go 80.00% 4 Missing and 2 partials ⚠️
cmd/vc-rest/startcmd/start.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   85.24%   84.78%   -0.46%     
==========================================
  Files         191      193       +2     
  Lines       17169    17495     +326     
==========================================
+ Hits        14636    14834     +198     
- Misses       2019     2129     +110     
- Partials      514      532      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit 75a15ee into main Nov 6, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants