feat:Add CRUD endpoints for tracer sessions and filter views in LangSmith API #168
Conversation
WalkthroughThe changes involve expanding the API capabilities for tracer sessions and filter views in the LangSmith OpenAPI specification. New endpoints have been added to provide comprehensive CRUD (Create, Read, Update, Delete) functionality for both tracer sessions and filter views, enabling more flexible management and interaction with tracing and filtering data within the system. Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/libs/LangSmith/openapi.yaml (1)
Line range hint
2442-2452: Ensure sensitive data handling in BasicAuthResponse schema.The BasicAuthResponse schema contains an access token. Consider adding format and pattern validations for the access_token field to ensure it meets security requirements.
BasicAuthResponse: title: BasicAuthResponse required: - access_token type: object properties: access_token: title: Access Token type: string + format: jwt + pattern: '^[A-Za-z0-9-_=]+\.[A-Za-z0-9-_=]+\.?[A-Za-z0-9-_.+/=]*$' + description: JWT access token with specific format requirements
🧹 Nitpick comments (2)
src/libs/LangSmith/openapi.yaml (2)
6362-6409: Security schemes are well-defined but consider enhancing security descriptions.The security schemes are properly configured, but consider adding more detailed descriptions for the ApiKey, TenantId, and OrganizationId schemes similar to the BearerAuth scheme's description.
ApiKey: type: apiKey name: X-API-Key in: header + description: API keys are used for authenticating API requests. Required for most endpoints. TenantId: type: apiKey name: X-Tenant-Id in: header + description: Tenant ID header required for workspace-scoped operations. OrganizationId: type: apiKey name: X-Organization-Id in: header + description: Organization ID header required for organization-scoped operations.
Line range hint
6075-6089: Consider adding rate limiting headers to the API specification.While usage tracking is implemented, consider adding standard rate limiting headers to the API responses.
responses: '200': description: Successful Response headers: + X-RateLimit-Limit: + description: Request limit per hour + schema: + type: integer + X-RateLimit-Remaining: + description: Remaining requests for the hour + schema: + type: integer + X-RateLimit-Reset: + description: Time until rate limit reset in UTC epoch seconds + schema: + type: integer
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/LangSmith/Generated/JsonSerializerContextTypes.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.AnnotationQueuesClient.GetRunsFromAnnotationQueue.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.IAnnotationQueuesClient.GetRunsFromAnnotationQueue.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (2)
src/libs/LangSmith/openapi.yaml (2)
Line range hint
1-7: LGTM! API version and server configuration look good.The OpenAPI specification version 3.0.4 is appropriate, and the server URL is correctly defined.
Line range hint
3182-3195: LGTM! Error handling schema is well-defined.The HTTPValidationError schema provides a good structure for validation errors with detailed location information.
Summary by CodeRabbit