Skip to content

Feat: add methods to retrieve liana active rules#54

Open
mr3wi wants to merge 3 commits intotrybeans:mainfrom
mr3wi:feat/add-methods-to-retrieve-rules
Open

Feat: add methods to retrieve liana active rules#54
mr3wi wants to merge 3 commits intotrybeans:mainfrom
mr3wi:feat/add-methods-to-retrieve-rules

Conversation

@mr3wi
Copy link
Contributor

@mr3wi mr3wi commented Sep 15, 2025

This will help to handle rule based operation.
eg: The join reward notice $notice_join_points display is normally based on the register rule, but there is no check if the rule is active or not. Which mean the notice display no matter the register rule active status.

Copy link
Contributor

@dlionel dlionel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't understand why you want to do that.
  2. This is probably a bad idea.

@mr3wi
Copy link
Contributor Author

mr3wi commented Dec 9, 2025

  1. I don't understand why you want to do that.
  2. This is probably a bad idea.

This:

This will help to handle rule based operation. eg: The join reward notice $notice_join_points display is normally based on the register rule, but there is no check if the rule is active or not. Which mean the notice display no matter the register rule active status.

@mr3wi mr3wi requested a review from dlionel December 9, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants