Skip to content

WIP: Bubbly #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Bubbly #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/vs/workbench/browser/parts/editor/media/multieditortabscontrol.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
.monaco-workbench .part.editor > .content .editor-group-container > .title > .tabs-and-actions-container {
display: flex;
position: relative; /* position tabs border bottom or editor actions (when tabs wrap) relative to this container */
margin: 6px 0px;
}

.monaco-workbench .part.editor > .content .editor-group-container > .title > .tabs-and-actions-container.empty {
Expand Down Expand Up @@ -77,6 +78,8 @@
display: flex;
height: var(--editor-group-tab-height);
scrollbar-width: none; /* Firefox: hide scrollbar */
gap: 6px;
padding: 0 6px;
}

.monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container.scroll {
Expand Down Expand Up @@ -116,9 +119,6 @@
.monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.active {
background-color: var(--vscode-tab-unfocusedActiveBackground);
}
.monaco-workbench .part.editor > .content .editor-group-container.active > .title .tabs-container > .tab.active {
background-color: var(--vscode-tab-activeBackground);
}

/* Tab Foreground Color in/active group/tab */
.monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab {
Expand All @@ -132,6 +132,8 @@
}
.monaco-workbench .part.editor > .content .editor-group-container.active > .title .tabs-container > .tab.active {
color: var(--vscode-tab-activeForeground);
border: 1px solid rgba(255, 255, 255, 0.1) !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The active tab styling now uses hard-coded rgba values with !important. Consider using theme variables to better support customization.

Suggested change
border: 1px solid rgba(255, 255, 255, 0.1) !important;
border: 1px solid var(--tab-border-color) !important;

background-color: rgba(0, 0, 0, 0.135) !important;
}

.monaco-workbench .part.editor > .content .editor-group-container.active > .title .tabs-container > .tab.selected:not(.active) {
Expand Down
1 change: 1 addition & 0 deletions src/vs/workbench/browser/parts/media/compositepart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
.monaco-workbench .part > .composite.header-or-footer,
.monaco-workbench .part > .composite.title {
display: flex;
margin: 6px 0px;
}

.monaco-workbench .part > .composite.title > .title-actions {
Expand Down
57 changes: 55 additions & 2 deletions src/vs/workbench/browser/parts/panel/media/panelpart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
display: none !important;
visibility: hidden !important;
}

/*
.monaco-workbench .part.panel.bottom .composite.title {
border-top-width: 1px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out border-top rule; consider removing instead of commenting if no longer needed.

border-top-style: solid;
}
} */

.monaco-workbench.nomaineditorarea .part.panel.bottom .composite.title {
border-top-width: 0; /* no border when main editor area is hiden */
Expand Down Expand Up @@ -98,3 +98,56 @@
display: inline-block;
transform: rotate(180deg);
}


/* TABS STYLING - styling for the container of the tabs */
.monaco-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item {
margin-right: 2px;
padding: 0 2px;
font-size: 12px;
text-transform: uppercase;
transition: all 0.2s ease;
background: transparent;
}

/* Style the tab labels to be bubbly */
.monaco-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .action-label {
border-radius: 10px;
padding: 2px 10px;
margin: 1px 0;
border: none !important;
background: var(--vscode-tab-inactiveBackground) !important;
}

/* HOVERED TABS */
.monaco-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:hover .action-label {
/* box-shadow: 0 1px 3px rgba(155, 155, 155, 0.05), inset 0 1px 0 rgba(255, 255, 255, 0.1); */

}
.monaco-workbench .panel {
padding: 6px;
}

/* ACTIVE TABS */
.monaco-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked .action-label {
background: rgba(0, 0, 0, 0.135) !important;
border: 1px solid rgba(255, 255, 255, 0.1) !important;
}

/* REMOVE ACTIVE TAB INDICATOR */
.monaco-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked .active-item-indicator:before {
border-top: none !important;
height: 0 !important;
}

.tab.tab-actions-right.sizing-fit.has-icon {
border-radius: 10px;
background-color: var(--vscode-tab-activeBackground);
}

.title .tabs.show-file-icons {
background: transparent !important;
}



2 changes: 2 additions & 0 deletions src/vs/workbench/browser/parts/views/media/views.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@
height: 24px;
font-size: 12px;
flex: 1;
border: 1px solid rgba(255, 255, 255, 0.1);
border-radius: 8px;
}

.pane-header .viewpane-filter-container > .viewpane-filter .monaco-inputbox .monaco-inputbox {
Expand Down
Loading