forked from microsoft/vscode
-
Notifications
You must be signed in to change notification settings - Fork 183
Setup environment.sh submodule fallback #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InSelfControll
wants to merge
4
commits into
main
Choose a base branch
from
setup-environment.sh-submodule-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+175
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to e012ae2 in 1 minute and 32 seconds. Click for details.
- Reviewed
245
lines of code in2
files - Skipped
2
files when reviewing. - Skipped posting
6
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:69
- Draft comment:
The new 'vscode-linux-x64-fast' script duplicates the memory flag (--max-old-space-size) for both node and gulp. Please confirm if both are needed. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment identifies a real inconsistency with how memory flags are used compared to other scripts. However, it's phrased as a question asking for confirmation rather than making a clear recommendation. The rules say not to ask authors to confirm things. Additionally, this could be considered a minor optimization that doesn't affect functionality. The duplicate flags might actually be intentional - maybe gulp needs its own memory setting separate from node's. Without understanding the gulp build system, I can't be certain this is a real issue. While the flags might be intentional, the inconsistency with other scripts and the lack of clear necessity for duplicate flags suggests this is likely unintended. The comment should be deleted because it's phrased as a question asking for confirmation rather than making a clear recommendation for change, violating the review rules.
2. scripts/pearai/setup-environment.sh:30
- Draft comment:
The execute() function uses eval without quoting the command. Consider quoting or refactoring to handle commands with special characters safely. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
3. scripts/pearai/setup-environment.sh:17
- Draft comment:
Using '==' for string comparison works in bash, but '=' is more portable. Confirm if this is intentional. - Reason this comment was not posted:
Confidence changes required:30%
<= threshold50%
None
4. scripts/pearai/setup-environment.sh:171
- Draft comment:
Relative path checks for PearAI-Roo-Code vary (using '../PearAI-Roo-Code' vs './extensions/PearAI-Roo-Code'). Ensure the directory structure is consistent and the correct paths are used. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. scripts/pearai/setup-environment.sh:132
- Draft comment:
Consider making the direct clone URLs configurable rather than hardcoding them, easing future modifications or forks. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The URLs were newly added in this PR as part of the fallback direct clone functionality. Making them configurable would improve maintainability and make it easier to use forks. However, these are fallback URLs that match the submodule configuration, so they likely shouldn't be different. The suggestion may add unnecessary complexity for an edge case fallback path. The URLs being configurable could be useful for development/testing or if the repos need to move. But it may rarely be needed since these are just fallbacks for when submodule commands fail. While technically valid, the suggestion adds complexity for an edge case. The URLs should match the submodule config, so having them configurable could lead to mismatches. The comment should be deleted. While not incorrect, making fallback URLs configurable adds unnecessary complexity for limited benefit.
6. scripts/pearai/setup-environment.sh:47
- Draft comment:
Enhanced logging with well-defined setup steps improves clarity – nice improvement. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_7IcF4w2dVnmx9TrR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance PearAI setup with faster Linux builds and robust submodule handling in
setup-environment.sh
.vscode-linux-x64-fast
script inpackage.json
for faster Linux builds using ESBuild, parallel processing, and memory optimization.setup-environment.sh
to clean up existing installations, initialize submodules, and set up symbolic links.This description was created by
for e012ae2. You can customize this summary. It will automatically update as commits are pushed.