feat: improve codespace init time & experience #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shem8
reviewed
Oct 15, 2024
.devcontainer/setup.sh
Outdated
| nohup bash -c "cd /wilco-agent && node agent.js &" >> /tmp/agent.log 2>&1 | ||
| nohup bash -c "cd /wilco-agent && node agent.js &" >> /tmp/agent.log 2>&1 | ||
|
|
||
| if command -v docker-compose &> /dev/null |
There was a problem hiding this comment.
if docker compose exists
| container_name: anythink-frontend-react | ||
| command: sh -c "cd frontend && yarn install && /wait-for-it.sh anythink-backend-java:3000 -t 120 --strict -- curl --head -X GET --retry 30 --retry-connrefused --retry-delay 1 anythink-backend-java:3000/api/ping && yarn start" | ||
| command: sh -c "cd frontend && /wait-for-it.sh anythink-backend-java:3000 -t 120 --strict -- curl --head -X GET --retry 30 --retry-connrefused --retry-delay 1 anythink-backend-java:3000/api/ping && yarn start" |
There was a problem hiding this comment.
yarn install is when users add packages
.framework/python/docker-compose.yml
Outdated
| @@ -1,6 +1,7 @@ | |||
| services: | |||
| anythink-backend-python: | |||
| build: ./backend | |||
| @@ -1,6 +1,6 @@ | |||
| services: | |||
| anythink-backend-java: | |||
| build: ./backend | |||
There was a problem hiding this comment.
if we do it, remove the Docker file from each directory
|
Remove the Dockerfile files, now that we don't need it |
shem8
approved these changes
Oct 20, 2024
@shem8 removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to make docker compose run faster.