Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/autocomplete #101

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Feat/autocomplete #101

merged 5 commits into from
Aug 15, 2024

Conversation

jusa3
Copy link
Collaborator

@jusa3 jusa3 commented Jul 2, 2024

Feature request: #98

Proposal: add new parameter compactStyle (see commits) @rombaum

@jusa3 jusa3 marked this pull request as draft July 2, 2024 08:45
@rombaum
Copy link
Collaborator

rombaum commented Jul 2, 2024

I think the name of the new parameter compactStyle is not clear enough and maybe confusing. E.g. small screens could also mean that the widget has a smaller width. In this case the height was changed and a possible description could not displayed anymore.

For this reason, I would suggest to swap the term compactStyle with something like singleSuggestionRow. In the documentation should be also a comment that maybe not all information would be shown by activating this mode.

@jusa3 jusa3 marked this pull request as ready for review July 17, 2024 13:34
@rombaum rombaum merged commit 84663fc into main Aug 15, 2024
2 checks passed
@rombaum rombaum deleted the feat/autocomplete branch August 15, 2024 11:28
@jusa3
Copy link
Collaborator Author

jusa3 commented Aug 15, 2024

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jusa3 jusa3 added the released label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants