Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply requested changes #662

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Apply requested changes #662

merged 4 commits into from
Feb 13, 2024

Conversation

victorgveloso
Copy link
Contributor

This PR modifies three aspects of the failing generated test case:

  1. Drop incorrect use of null literal
  2. Rename new parameter
  3. Increase the number of expected parameterize test refactoring (from one to two)

@tsantalis
Copy link
Owner

@victorgveloso
enum is a reserved Java keyword.
Please use another name for the parameter.
The JDT Parser will most probably fail to parse it.

@victorgveloso victorgveloso force-pushed the fix/enum-package-code-gen branch from 88d0de8 to 683d2d3 Compare February 13, 2024 16:56
@tsantalis tsantalis merged commit 5f54bc3 into tsantalis:master Feb 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgveloso @tsantalis