Fix bottom layer component placement in GLTF/GLB generation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getComponentYPosition helper function for layer-aware positioning - Bottom layer components now placed below PCB board (Y < 0) - Top layer components remain above PCB board (Y > 0) - Backward compatible: components without layer default to top - Add comprehensive unit and visual tests - Resolve missing dependencies for test suite Fixes tscircuit#34
2 tasks
|
@RaghavArora14 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
- Add extra clearance for bottom components to improve visibility - Create comprehensive visual tests with multiple components - Update test tolerance to account for enhanced positioning - Optimize camera angles for better component visualization
- Reduce texture resolution from 256 to 128 for faster CI execution - Add 15 second timeout to board texture test to prevent CI failures - Fix code formatting issues with trailing whitespace - Board texture test now completes in ~2 seconds instead of timing out
- Remove package-lock.json (auto-generated, should not be committed) - Remove redundant bottom-layer-components test that didn't show clear visual difference - Keep angled-view test that clearly demonstrates bottom layer component placement - Maintain clean test suite with meaningful visual evidence
Keep only the angled-view test that clearly shows component placement
Remove unnecessary changes to test resolution and timeout
RaghavArora14
force-pushed
the
fix/bottom-layer-component-placement
branch
from
46bd365 to
15cc039
Compare
Contributor
|
i think @MustafaMulla29 might have fixed this already |
Contributor
Author
|
Yes I think we published our prs around the same time |
Contributor
Author
|
@seveibar if there's anything from my pr you'd like to merge feel free to. Loved working on this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bottom layer component placement in GLTF/GLB generation
Fixes #34 - Bottom layer components are now correctly positioned below the PCB board surface.
Changes
layer: "bottom"are placed below the board with proper clearanceTechnical Details
Y = -(boardThickness/2 + componentHeight/2 + 0.7mm)Y = boardThickness/2 + componentHeight/2Validation
Ready for review and merge.
Behavior
"top""bottom"undefinedThe fix is demonstrated by the included snapshot test which shows components correctly distributed above and below the PCB board, instead of all components floating above it.
/claim #34
/fixes #34
closes #34