Merge pull request #57 from tscircuit/fix/arduino-nano

fix: get the unconnected pads as well in nets list
tscircuit · Dec 9, 2024 · 1c631de · 1c631de
2 parents c0a3968 + a434061
commit 1c631de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/dsn-pcb/circuit-json-to-dsn-json/process-nets.ts b/lib/dsn-pcb/circuit-json-to-dsn-json/process-nets.ts
@@ -30,9 +30,9 @@ export function processNets(circuitElements: AnyCircuitElement[], pcb: DsnPcb) {
         if (sourcePort && "source_component_id" in sourcePort) {
           const componentName =
             componentNameMap.get(sourcePort.source_component_id) || ""
-          // "A12" -> "12", "B1" -> "1 (When pinNumber a)
-          const pinNumber =
-            element.port_hints?.[0]?.match(/(?:A|B)?(\d+)/)?.[1] || "1"
+          const pinNumber = sourcePort.port_hints?.find(
+            (hint) => !Number.isNaN(Number(hint)),
+          )
 
           padsBySourcePortId.set(sourcePort.source_port_id, {
             componentName,

diff --git a/tests/repros/repro-4-arduino-nano.test.ts b/tests/repros/repro-4-arduino-nano.test.ts
@@ -40,5 +40,5 @@ test("circuit json (arduino nano) -> dsn file", async () => {
   // padstack length
   expect(dsnJson.library.padstacks.length).toBe(10)
   // net length
-  expect(dsnJson.network.nets.length).toBe(63)
+  expect(dsnJson.network.nets.length).toBe(72)
 })