Improved smoothie board parsing & added an isolated test for next issue #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
reviewed
Feb 15, 2025
lib/utils/get-pin-details.ts
Outdated
| import { getPinNum } from "lib/utils/get-pin-number" | ||
|
|
||
| const debug = Debug("dsn-converter:get-pin-details") | ||
| export function getPinDetails(nodes: any[]): Pin | null { |
There was a problem hiding this comment.
can you improve the type here? it was originally like AstNode? I feel like one way we can make things more maintanble is improving types or at least preventing type regressions
|
@Abse2001 Is the rotation not working? Cause I remember that I have routed the arduino which has the rotated chip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next issue will be the rotation of components Im working on it.
should be rotated.
