CPAN compliant and TAP compliant 🎁 #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to see Prokka in CPAN! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a Makefile.PL so that Prokka is CPAN-compliant. This also makes things more streamlined in Travis-CI.
prokka.MANIFESTformake dist, if you decide to upload to cpan.t/05_prokka.twhich is invoked withmake testorperl t/05_prokka.t.t/and will be run in alphanumeric order. I chose to start the unit test script with 05 in case there were a future test that should be run before this one.sedwith pure perl to help with error checking and/or any issues with subshells at that stage.All tests defined by @tseemann pass in travis-ci.