Recipe App 👨💻 👨💻 #17
Conversation
Setting up environment and devise
General Shopping List
Co-Authored-By: Gladwin Tshepo Ramantso <tshepo.ramantso@outlook.com>
Co-Authored-By: Gladwin Tshepo Ramantso <tshepo.ramantso@outlook.com>
Co-Authored-By: Gladwin Tshepo Ramantso <tshepo.ramantso@outlook.com>
Navbar n+1 test
There was a problem hiding this comment.
Hi @tsheporamantso @Fombi-Favour 👋🏼👋🏼👋🏼,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights✅✅✅
- Account management is built using devise👍🏼.
- Unit and integration tests have been written and all tests are passing👍🏼.
-
n+1concerns have been taken care of👍🏼. - Nice job implementing the toggle button for making a recipe public👍🏼.
- github flow is used👍🏼.
- Linters are passing👍🏼.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/views/recipes/show.html.erb
Outdated
| </div> | ||
|
|
||
| <div class="btns"> | ||
| <%= button_to "Generate Shopping List", "", class: "add-food-link"%> |
There was a problem hiding this comment.
Nice job so far👍🏼. I noticed that when the Generate shopping list button is clicked, an error is rendered which breaks the app, even though the shopping list is generated. Kindly fix this, as this can lead to a poor user experience. I suggest that when the button is clicked, it should lead the user to the general shopping list view so the user can see the result of his actions😉.
app/views/recipes/new.html.erb
Outdated
| <%= form_with(model: @recipe, url:user_recipes_path(@user), local: true, method: :post) do |form| %> | ||
| <div> | ||
| <%= form.label :name %><br> | ||
| <%= form.text_field :name, autocomplete: 'off' %> | ||
| </div> | ||
|
|
||
| <div> | ||
| <%= form.label :description %><br> | ||
| <%= form.text_area :description %> | ||
| </div> | ||
|
|
||
| <div> | ||
| <%= form.label :preparation_time %><br> | ||
| <%= form.number_field :preparation_time, in: 1..1000, step: 1, autocomplete: "off" %> | ||
| </div> | ||
|
|
||
| <div> | ||
| <%= form.label :cooking_time %><br> | ||
| <%= form.number_field :cooking_time, in: 1..1000, step: 1, autocomplete: "off" %> | ||
| </div> | ||
|
|
||
| <div> | ||
| <%= form.label :public %><br> | ||
| <%= form.check_box :public %> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
I noticed you added validation to all your forms, which is a good practice😉. The issue currently is that, for all your input fields or forms, whenever a user proceeds to submit with any empty field, it breaks the app. This can lead to a poor user experience. If a field is not provided, I suggest you send an error message to the user on the same page or you can use the required HTML attribute that prevents the user from submitting the form automatically😉.
In summary, let's find a way of preventing the user from submitting a form with empty fields, but without breaking the app👍🏼. Please remember to implement this for all your forms😉.
There was a problem hiding this comment.
Status: Approved 🟢 🟢 🟢
Hi Team,
Good job working on the changes highlighted by the previous reviewer 👍🏽
You guys did a great work. Keep it up 👍🏽
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉
Highlights:
✅ You set up Gitflow correctly 👍🏽
✅ The Linter checks passed successfully 👍🏽
✅ Good descriptive PR and README file 👍🏽
✅ Good commit messages 👍🏽
✅ The app works fine and all features were implemented as expected 👍🏽
✅ Implemented tests and all tests passed successfully 👍🏽
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Recipe App 👨💻 👨💻
On this milestone we implemented the following
Login page and registration page:
Recipes list:
Public recipe list:
Recipe details:
Make sure there are no N+1 queries happening.
Create a navigation menu that allows users to open all of the pages you created.
Write unit and integration tests
Food list:
General shopping list view:
Check and correct Rubocop offences
Check and correct Stylelint errors