A small quality of life change where select is unfocused after choosing an option #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if you select snake game and start pressing W A S D, the browser selects one of the options from select again.
This is not ideal behavior because we expect our inputs to work on the canvas instead of the select tag, so you must click on the canvas to start playing.
The same case happens in the
core_input_keys
example where you need to click on the canvas to start accepting new inputs.The downside of the implementation:-
You lose focus from select element even for non-interactive examples that require some flag per example in the codebase which I don't know if you want or not