Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small quality of life change where select is unfocused after choosing an option #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hiranyey
Copy link

So if you select snake game and start pressing W A S D, the browser selects one of the options from select again.
This is not ideal behavior because we expect our inputs to work on the canvas instead of the select tag, so you must click on the canvas to start playing.

The same case happens in the core_input_keys example where you need to click on the canvas to start accepting new inputs. 

The downside of the implementation:-
You lose focus from select element even for non-interactive examples that require some flag per example in the codebase which I don't know if you want or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant