Bad format #916
Closed
Bad format #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have a look at the following commit to see when the move from DWARF 4 to 5 first happened upstream: llvm@d3b26de?diff=unified
Actions triggered by pull_request_target events have access to all repository secrets, so it is unsafe to use them when executing untrusted code. The pr-code-format workflow does not execute any untrusted code, but it passes untrused input into clang-format. An attacker could use this to exploit a flaw in clang-format and potentially gain access to the repository secrets. By splitting the workflow, we can use the pull_request target which is more secure and isolate the issue write permissions in a separate job.
You can test this locally with the following command:git-clang-format --diff acdf3338fe201f01bd50382dff7a4a8fa8cbac06 b6397024223cc0c74b068efe4b7a07b0931b8dc5 -- llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cppView the diff from clang-format here.diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
index afdcbece1a..0f3bb3e7b0 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -578,7 +578,7 @@ AMDGPUTargetMachine::AMDGPUTargetMachine(const Target &T, const Triple &TT,
FS, Options, getEffectiveRelocModel(RM),
getEffectiveCodeModel(CM, CodeModel::Small), OptLevel),
TLOF(createTLOF(getTargetTriple())) {
- initAsmInfo();
+ initAsmInfo();
if (TT.getArch() == Triple::amdgcn) {
if (getMCSubtargetInfo()->checkFeatures("+wavefrontsize64"))
MRI.reset(llvm::createGCNMCRegisterInfo(AMDGPUDwarfFlavour::Wave64));
|
tstellar
force-pushed
the
main
branch
4 times, most recently
from
758197f to
f8063ff
Compare
tstellar
force-pushed
the
main
branch
2 times, most recently
from
cec969f to
78a6a05
Compare
tstellar
force-pushed
the
main
branch
2 times, most recently
from
720e09b to
d093e40
Compare
tstellar
force-pushed
the
main
branch
4 times, most recently
from
2cd0b2a to
a88f2fc
Compare
tstellar
force-pushed
the
main
branch
3 times, most recently
from
f897b77 to
6e1d1c5
Compare
tstellar
force-pushed
the
main
branch
3 times, most recently
from
bf47e71 to
be7f182
Compare
tstellar
force-pushed
the
main
branch
2 times, most recently
from
d13be87 to
af34a23
Compare
tstellar
force-pushed
the
main
branch
2 times, most recently
from
3a014cf to
17c05f6
Compare
tstellar
force-pushed
the
main
branch
4 times, most recently
from
8bff7cc to
3bd3e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.