Don't add videos to podcast until they are done streaming

tsubery · Sep 26, 2024 · 1c0f08b · 1c0f08b
1 parent a0d8f92
commit 1c0f08b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/app/models/media_item.rb b/app/models/media_item.rb
@@ -36,7 +36,7 @@ def fill_missing_details
 
     if %r{\Ahttps://(www\.)?(youtube|vimeo)\.com/} =~ url || %r{\Ahttps://youtu\.be/} =~ url
       info = Youtube::Video.new(url).get_information
-      if info.present?
+      if info.present? && !info["is_live"]
         success = !!info["id"]
         if success && info['extractor'] == 'youtube'
           video = Youtube::Video.from_id(info["id"])

diff --git a/test/fixtures/media_items.yml b/test/fixtures/media_items.yml
@@ -41,3 +41,7 @@ xss_article:
   title: evil
   description: <script>alert("injection")</script>
 
+live_video:
+  feed: one
+  url: https://www.youtube.com/watch?v=PRWclJd_sIQ
+  guid: https://www.youtube.com/watch?v=PRWclJd_sIQ
diff --git a/test/fixtures/youtube_cli/get_video_information-4574299a36ee851da8cd20da1356dc84.json b/test/fixtures/youtube_cli/get_video_information-4574299a36ee851da8cd20da1356dc84.json
diff --git a/test/models/media_item_test.rb b/test/models/media_item_test.rb
@@ -23,6 +23,13 @@ class MediaItemTest < ActiveSupport::TestCase
     assert_not yt.reachable
   end
 
+  test "fill_missing_info waits until video is done streaming" do
+    yt = media_items(:live_video)
+    assert_equal '', yt.title
+    yt.fill_missing_details
+    assert_equal '', yt.title
+  end
+
   test "embedding images and resolving links" do
     original_html = File.read("test/fixtures/articles/substack_email.html")
     VCR.use_cassette("embedded-images-test", record: :new_episodes) do