-
Notifications
You must be signed in to change notification settings - Fork 15
Fix typos #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix typos #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks again for finding time to make improvements.
index.html is generated from index.cirru and code-files defined in there.
https://github.com/ttu/kotlin-is-like-csharp/blob/1326faf5a49283dcfb9ea7c99a3120d236945e52/index.cirru
e.g.
for (i in 0..<count) {
println("Person ${i + 1} is called ${names[i]}")
}
can be found from https://github.com/ttu/kotlin-is-like-csharp/blob/1326faf5a49283dcfb9ea7c99a3120d236945e52/code/range-operator.kt
Would you like to make changes to code files and regenerate the index.html?
On README there is a guide how to regenerate the file.
https://github.com/ttu/kotlin-is-like-csharp?tab=readme-ov-file#develop
@ttu apologies for the incredibly long delay. I got quite busy with school along with other personal events. I figured it might be good to replace I was looking into the use of the We would need to reimplement many of its features to remove On another note, I am quite unfamiliar with CoffeeScript. From the looks of it, you were using it for Overall, I'm not too worried about CoffeeScript, but I am mainly concerned about the use of |
@megabyte6 Thanks for the interest. This project was based on the other Just let me know if you have some questions and feel like trying to modernize the tools used in this project. |
@ttu Oh I see. In that case, I agree with you. There would have to be huge changes, possibly across multiple projects. I'll just make the changes you recommended, namely adding |
@ttu Alright, this pull request has been updated with the fixes you recommended. |
Mainly fixes typos and the misuse of
<
in HTML by replacing them with<
.Requested in #13