Skip to content

fix: Sontex HCA support. They used some VIFs from 0xFD table that we didn't implement #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tudborg merged 1 commit into from
Apr 7, 2025
Merged

fix: Sontex HCA support. They used some VIFs from 0xFD table that we didn't implement #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/exmbus/parser/apl/data_record/value_information_block/vif_table_fd.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ defmodule Exmbus.Parser.Apl.DataRecord.ValueInformationBlock.VifTableFD do
def parse(<<e::1, 0b010_11::5, 0b01::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_size_last_readout, :minute}}})
def parse(<<e::1, 0b010_11::5, 0b10::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_size_last_readout, :hour}}})
def parse(<<e::1, 0b010_11::5, 0b11::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_size_last_readout, :day}}})
# Tariff related VIFs
def parse(<<e::1, 0b0110000::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: :start_of_tariff}})
def parse(<<e::1, 0b01100::5, 0b01::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_of_tariff, :minute}}})
def parse(<<e::1, 0b01100::5, 0b10::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_of_tariff, :hour}}})
def parse(<<e::1, 0b01100::5, 0b11::2, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: {:duration_of_tariff, :day}}})
# ... skipped some vifs ...
def parse(<<e::1, 0b011_1010::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: :dimensionless}})
def parse(<<e::1, 0b011_1011::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: {:container, :wmbus}}})
Expand All @@ -59,14 +64,16 @@ defmodule Exmbus.Parser.Apl.DataRecord.ValueInformationBlock.VifTableFD do
def parse(<<e::1, 0b110_0000::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: :reset_counter}})
def parse(<<e::1, 0b110_0001::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: :cumulation_counter}})
# ... skipped some vifs ...
def parse(<<e::1, 0b110_0110::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: :state_of_parameter_activation}})
# ... skipped some vifs ...
def parse(<<e::1, 0b111_0001::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: :rf_level_units_dbm}})
# ... skipped some vifs ...
def parse(<<e::1, 0b111_0100::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: :remaining_battery_life_time_days}})
def parse(<<e::1, 0b111_0101::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, coding: fd_remark_k(ctx), description: :number_of_times_meter_was_stopped}})
def parse(<<e::1, 0b111_0110::7, rest::binary>>, ctx), do: Vife.parse(e, rest, %{ctx | vib: %VIB{table: :fd, description: {:container, :manufacturer}}})
# ... skipped some vifs ...
def parse(<<_::1, vif::7, rest::binary>>, ctx) do
raise "decoding from VIF linear extension table 0xFD not implemented. VIFE was: #{Exmbus.Debug.to_hex(vif)} (#{Exmbus.Debug.to_bits(vif)}), ctx was: #{inspect ctx}, rest was: #{inspect rest}"
def parse(<<e::1, vif::7, rest::binary>>, ctx) do
raise "decoding from VIF linear extension table 0xFD not implemented. VIFE was: #{Exmbus.Debug.to_hex(vif)} (E#{Exmbus.Debug.to_bits(<<vif::7>>)}) (E=#{e}), ctx was: #{inspect ctx}, rest was: #{inspect rest}"
end


Expand Down
Loading
Loading