Fix string equals if other is null and string constant pool #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop from internedString to host and back to guest crashes the constant handling in the constant pool. I think, it should be sufficient to just hand over the internedString to SPouT and add it to the pool. String equals has not gracefully handled comparison with null in all cases
mmuesly
commented
Oct 4, 2023
| @@ -2136,11 +2136,9 @@ private void putPoolConstant(VirtualFrame frame, int top, char cpi, int opcode) | |||
| } else if (constant instanceof StringConstant) { | |||
| assert opcode == LDC || opcode == LDC_W; | |||
| StaticObject internedString = pool.resolvedStringAt(cpi); | |||
| Meta meta = getMeta(); | |||
| StaticObject obj = meta.toGuestString(meta.toHostString(internedString)); | |||
There was a problem hiding this comment.
@fhowar I don't know why you added this and whether it is really necessary.
The constant op code does not need it and all other exceptions should be handled in the markObjectWithIfTaint method, IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop from internedString to host and back to guest crashes the constant handling in the constant pool. I think, it should be sufficient to just hand over the internedString to SPouT and add it to the pool. String equals has not gracefully handled comparison with null in all cases.
This PR is recommended as replacement to #2. I personally prefer the loop over the underlying VM wherever possible instead of faithfully modeling the string library behavior in the substitution methods.