Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of min segment count #14

Conversation

tillschallau
Copy link
Member

The value of MIN_SEGMENT_COUNT was not correctly considered.
Change comparison of segment count to ">=" instead of ">"

@tillschallau tillschallau self-assigned this Nov 15, 2023
@tillschallau tillschallau linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2807626) 28.26% compared to head (ba7056f) 28.26%.

Files Patch % Lines
...tools/aqua/stars/importer/carla/RunSegmentation.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   28.26%   28.26%           
=======================================
  Files          27       27           
  Lines        2204     2204           
  Branches      281      281           
=======================================
  Hits          623      623           
  Misses       1553     1553           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tillschallau tillschallau merged commit 2cf0f9f into main Nov 15, 2023
18 checks passed
@tillschallau tillschallau deleted the 10-segment-count-is-not-equal-to-the-previous-stars-main-repository branch November 15, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment count is not equal to the previous stars-main repository
1 participant