-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add e-lab testimonials #51
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Overall looks good.
Here are some remaining points: You're still failing some checks:
I think the hero text looked better with left align. Any other opinions on that? @Max-vS @MunzerDw The testimonials look nice and work really well |
The size of Florian Scherls picture in the Testimonials is not a perfect circle, causing some arrangement issues. |
I think the issue with the Header on mobile, can be resolved by adding a margin to the top, when a certain media width is reached. Can be easily done with Tailwinds responsive features. |
It's not really an issue with margins but instead that this navigation was never intended to have 7 top level links. For smaller screens like that we need some overflow scrolling |
…to text center again, on mobile it's still centered || formatted with yarn format
But when the PR Title passes it should be fine, shouldn't it? |
I also cropped the photo from florian |
I also added a video instead of the photo |
* Ready to publish for Application Phase starting on 01.08 || Added Testimonials * Ready to publish for Application Phase starting on 01.08 || Added Testimonials || formatted * formatted wit prettier * swapped the links from aielab.tum... to /e-lab || switched the title to text center again, on mobile it's still centered || formatted with yarn format --------- Co-authored-by: timonschramm <timonschramm@t-online.de>
Hi there,
this website should be used starting on 01.08.
The Links for the application are currently pointing to unfinished Tallyforms, but they will be finished before the 01.08.
Please also change the Link in the navbar to the correct site then.
Thank you so much.
P.S The navbar looks still odd on phones