Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubectl and helm code added in readme.md #130

Closed
wants to merge 1 commit into from
Closed

Kubectl and helm code added in readme.md #130

wants to merge 1 commit into from

Conversation

adiltamboli12
Copy link
Contributor

Closes: #96

Changes

  • Added the code in readme

@tungbq tungbq mentioned this pull request Mar 18, 2024
Closed
@tungbq
Copy link
Owner

tungbq commented Mar 18, 2024

Hi @adiltamboli12 thanks for your PR #130. It's really nice, I appreciate your contribution in this repository.
Just would like to close it as @Chrisgr1 has already been assigned the ticket before your PR.
So, I would prefer using the PR from @Chrisgr1 (#132) instead of #130. I hope you could understand this situation. Thanks!

Again, thanks for your contribution! If you want to contribute more on this repo, you could find other good first issue to work on. Thanks!

@tungbq tungbq closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungbq tungbq Awaiting requested review from tungbq tungbq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the sample code from samples/run_sample.sh to samples/README.md
2 participants
@adiltamboli12 @tungbq