use host after all, map service ports to host

tunnelworks · Oct 21, 2024 · 74615ce · 74615ce
1 parent ec40ec1
commit 74615ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -29,6 +29,8 @@ jobs:
         image: postgres:${{ matrix.postgres-version }}
         env:
           POSTGRES_PASSWORD: "1234"
+        ports:
+          - "5432:5432"
         options: >-
           --health-cmd pg_isready
           --health-interval 10s
@@ -52,5 +54,4 @@ jobs:
       - name: Run tests
         run: hatch test --python ${{ matrix.python-version }} --cover --randomize --parallel --retries 2 --retry-delay 1
         env:
-          POSTGRES_HOSTADDR: "postgres"
           POSTGRES_DB: "postgres"
diff --git a/tests/db/conftest.py b/tests/db/conftest.py
@@ -14,8 +14,8 @@ def namespace() -> str:
 
 
 @pytest.fixture(scope="session")
-def hostaddr() -> str:
-    return os.getenv("POSTGRES_HOSTADDR", "127.0.0.1")
+def host() -> str:
+    return os.getenv("POSTGRES_HOST", "127.0.0.1")
 
 
 @pytest.fixture(scope="session")
@@ -35,13 +35,13 @@ def password() -> str:
 
 @pytest.fixture(scope="session")
 def conninfo(
-    hostaddr: str,
+    host: str,
     dbname: str,
     username: str,
     password: str,
 ) -> str:
     return config.ConnectionInfo(
-        hostaddr=hostaddr,
+        host=host,
         dbname=dbname,
         username=username,
         password=password,