Skip to content

Kristen Bair #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Kristen Bair #189

wants to merge 18 commits into from

Conversation

kristenmb
Copy link

Mod 1 Pre-Work Submission

@francepack
Copy link
Contributor

@kristenmb

-In your classes, when you set a default value for an attribute, for example, saying this.sleepy = true rather than this.sleepy = sleepy, that means you do not need to pass that variable through as a parameter. In this example, clean could be taken out of your constructor since you do not need to pass in a value every time you make an instance.

  • For speckled frogs, try to find a solution where that just involves calling a function once. This function should take the amount of monkeys you will account for as a parameter.

  • With your Ceasar cipher, I think you have a good start. A couple of next steps could be to put your logic inside of a function. This function could take a parameter that is your phrase. I see you've made a phrase into an array- I'd say using the .split method is a more common way to do this than using Array.from. When you have a split array, you could find each letter in your alphabet array, and move a certain amount of indexes away from that to grab a new letter.

  • For fizzbuzz, you've taken a unique approach! This delivers all your results at once in an array, which is pretty neat, but also a little clunky. I do like the pattern you used of declaring a variable, then adding something to that variable based on a for loop. In cases like this, you can just say var fizzbuzzArray = [].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants