Brian Forbes

[Codeherder19]

No description provided.

[francepack]

@Codeherder19
Nice work here! Just a few bits of feedback as you continue to prepare for Turing:

• Really like seeing the progress in your analysis of the checkerboard problem through your pseudocode. Nice work there! How you write pseudocode is an evolving process, and I think it can really help to use some visual elements to keep thoughts organized. I also encourage you to try some more actual coding of these problems in the time leading up to your start date!

• Nice job using a for loop to print speckled frogs the correct number of times. A couple things I notice here- You'll typically see i++ rather than i-- used in for loops. You can achieve similar loops with both, as the one you have here works just fine, but using i++ is more consistent for other developers understanding, and I find it helps me access elements in an array in a more organized way. Leading to the second thing- I do not see any reference to you numWords array inside of your loop. Rather than just print i in your story, you could access elements of that array by bracket notation using i. You may need to think about how that array is set up versus what element you want to grab when, for example, the first time I run through this loop, the way it is set up now, i starts with a value of 10, so you'd be wanting to grab your first word from numWords based on that value. If you did change to i++, you'd just want to be careful to reconfigure how that is set up.

• A couple things I wanted to mention that I saw n your class work. First, In your human class, since you have bodyOdor and numberOfDigits listed as parameters within your constructor method, I'd expect to see any instantiation of that class needing to be given that information. Specifically, when you create an instance on line 24, you need to give new Person some parentheses and data to hold in its attributes.
  Second, I like the idea of the interaction between numberOfDigits and woodShopAccident, but I think your method here could be a bit more nuanced. For example, you, instance brian, had a woodShopAccident and now have 9 digits. As it stands, you could call brian.woodShopAccident(10) and brian would have 10 fingers again! I think woodShopAccident seems more like a method where this.numberOfDigits = this.numberOfDigits - input

[Codeherder19]

Thanks for the feedback! I was wondering if no news was good or bad at this point. I assumed you guys had plenty of things to work through and review. I will look over the parts you’re referring to and make note of your recommendations. I’m actually going to start working on the other recommended extensions leading up to October 5th, and I am going to try my hand at actually coding the checkerboard as well as seeing if I can figure out the Caesar cipher. I did not realize there is a “ - input” command I could insert, but I understand what you’re saying. In this realistic example, I couldn’t gain fingers back, unless I created another method like “regenerateDigit” or “surgery” for example. numberOfDigits should have a declared value of 10 to start, and only be able to be decreased incrementally and not increased. I guess I misunderstood the applications of i++ versus i- - . I thought I had to use i - - to iterate down through the index and i ++ to iterate up through the index. Sounds like i++ is what you guys refer to as “best practice” so I will definitely make note of that. As far as referencing numWords, did you scroll down far enough? I’m looking over my speckledFrogs.js right now and I have two chunks of code written. The one up top satisfies the initial problem and the extension of running it any number of times. The second code block references numWords[i] with bracket notation and I ran it to make sure it replaces the numbers with the words that represent them. I also checked just now to make sure I didn’t accidentally make those changes to spekcledFrogs.js and forget to commit and push them but I just ran for status and my working tree is clean. Please let me know if you can see the bit of code where I solve for extension 1 printing word versions for each number. I realize now looking over my code that I did not create a full instance in my person.js exercise! I did not declare any parameters! That was definitely a bonehead move and an oversight on my part. I’ll do better about being thorough. Believe it or not, I did review my homework and caught a lot of little errors or missed answers etc. so I am grateful you only had the limited notes that I see in this email. I appreciate all the feedback Mason! I am finally done with work so I’ll be spending at least 4-8 hours a day on the other recommended extensions as well as the checkerboard and cipher extensions leading up to October 5th. Is there an order you recommend I go through these links/problems? For example, would it be best for me to tackle ALL of the javascript resources first, or should I do a little bit of that and then maybe dip my toes into the HTML and CSS resources? What about the Design, UX, and UI resources? Just wondering what you think is best, if I should go down the list or bounce around a bit. Thanks again Mason! I look forward to class on October 5th. If you have any other hints or tips for me they would be greatly appreciated! Have a great day! Regards, -Brian Forbes

…

On Tue, Sep 22, 2020 at 12:35 PM Mason France ***@***.***> wrote: @Codeherder19 <https://github.com/Codeherder19> Nice work here! Just a few bits of feedback as you continue to prepare for Turing: - Really like seeing the progress in your analysis of the checkerboard problem through your pseudocode. Nice work there! How you write pseudocode is an evolving process, and I think it can really help to use some visual elements to keep thoughts organized. I also encourage you to try some more actual coding of these problems in the time leading up to your start date! - Nice job using a for loop to print speckled frogs the correct number of times. A couple things I notice here- You'll typically see i++ rather than i-- used in for loops. You can achieve similar loops with both, as the one you have here works just fine, but using i++ is more consistent for other developers understanding, and I find it helps me access elements in an array in a more organized way. Leading to the second thing- I do not see any reference to you numWords array inside of your loop. Rather than just print i in your story, you could access elements of that array by bracket notation using i. You may need to think about how that array is set up versus what element you want to grab when, for example, the first time I run through this loop, the way it is set up now, i starts with a value of 10, so you'd be wanting to grab your first word from numWords based on that value. If you did change to i++, you'd just want to be careful to reconfigure how that is set up. - A couple things I wanted to mention that I saw n your class work. First, In your human class, since you have bodyOdor and numberOfDigits listed as parameters within your constructor method, I'd expect to see any instantiation of that class needing to be given that information. Specifically, when you create an instance on line 24, you need to give new Person some parentheses and data to hold in its attributes. Second, I like the idea of the interaction between numberOfDigits and woodShopAccident, but I think your method here could be a bit more nuanced. For example, you, instance brian, had a woodShopAccident and now have 9 digits. As it stands, you could call brian.woodShopAccident(10) and brian would have 10 fingers again! I think woodShopAccident seems more like a method where this.numberOfDigits = this.numberOfDigits - input — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQUKDMN3N4LPZVFHXVY73J3SHDU6VANCNFSM4RJYP37A> .