Paul Knapp #11
Paul Knapp #11
Conversation
|
|
||
| def initialize(info) | ||
| @name = info[:name] | ||
| @price = info[:price] |
There was a problem hiding this comment.
The interaction pattern asks to clean the string (remove the dollar sign) and convert to a float!
There was a problem hiding this comment.
Great commit history - nice stuff Paul!
| @@ -0,0 +1,2 @@ | |||
| --format documentation | |||
| --color | |||
| end | ||
|
|
||
| def sorted_item_list | ||
| vendors.flat_map { |vendor| vendor.inventory.keys.map(&:name)}.uniq.sort |
| def total_inventory | ||
| all_inventory = {} | ||
|
|
||
| @vendors.each do |vendor| |
There was a problem hiding this comment.
Theres probably an easier way to do this. Ask perplexity for some refactoring tips!
|
|
||
| def potential_revenue | ||
| @inventory.sum do |item,quantity| | ||
| item.price.gsub('$', '').to_f * quantity |
There was a problem hiding this comment.
Youre cleaning the string here!! Nice. Do it on the item instantiation, though.
| end | ||
|
|
||
| def stock(item, quantity) | ||
| @inventory[item] = (@inventory[item] || 0 )+ quantity |
| it '#exists' do | ||
| expect(@market).to be_an_instance_of(Market) | ||
| end | ||
|
|
||
| it '#has a name' do | ||
| expect(@market.name).to eq ("South Pearl Street Farmers Market") | ||
| end | ||
|
|
||
| it '#has no vendors' do | ||
| expect(@market.vendors).to eq([]) | ||
| end |
There was a problem hiding this comment.
Functionality that happens in the instantiation can be consolidated into a single test, if you'd like to save time and lines.
| end | ||
|
|
||
| it '#can show vendors that sell an item' do | ||
| @vendor1.stock(@item1, 35) |
There was a problem hiding this comment.
Consider testing stock in isolation. This is a nice test though, I have no problem with what you did here.
two methods for iteration 3 + passes all written tests