Oscar Submission #14
Oscar Submission #14
Conversation
| def initialize (info) | ||
| @name = info[:name] | ||
| @price = info[:price] | ||
| #takes out all weird characters and symbols then convert to float |
There was a problem hiding this comment.
Nice note here! You could have done the below method in the initialize function instead, but this works!
| @market.add_vendor(@vendor1) | ||
| @vendor1.stock(@item1, 35) | ||
| @vendor1 | ||
|
|
There was a problem hiding this comment.
You're missing an end here! Better indentation and conventions could have make this easy to see! Please continue to work on this!
|
|
||
|
|
||
| def stock(item, amount) | ||
| if @inventory.include?(item) |
There was a problem hiding this comment.
Great method here! Checking it includes the item, and += the quantity
| end | ||
|
|
||
| def price | ||
| @price.gsub(/[^\d.]/, '').to_f |
There was a problem hiding this comment.
Do you know what this regex is doing here! It works, but regex and can be confusing. Make sure you know whats going on with this code! You could have used the string method .delete("$") here to the same effect.
|
|
||
|
|
||
| def add_vendor(vendor) | ||
|
|
There was a problem hiding this comment.
vendors << vendor would go here.
| @market.add_vendor(@vendor2) | ||
| @market.add_vendor(@vendor3) | ||
| expect(@market.vendors).to eq [@vendor1, @vendor2, @vendor3] | ||
| expect(@market.vendor_names).to eq[] |
There was a problem hiding this comment.
This is a good test! Just needed to finish the method that does the logic.
| @@ -1,3 +1,30 @@ | |||
| class Vendor | |||
| attr_reader :name | |||
|
|
|||
| attr_accessor :inventory | |||
There was a problem hiding this comment.
This could probably exist as an attr_reader. You're not going to update this value directly outside of this class.
No description provided.