Danielle Cardona #3
Conversation
|
|
||
| def initialize(attributes) | ||
| @name = attributes[:name] | ||
| @price = attributes[:price] |
There was a problem hiding this comment.
The interaction patterns asks to clean the string (remove the $) and convert to a float.
| attr_reader :name, | ||
| :date | ||
|
|
||
| attr_accessor :vendors |
There was a problem hiding this comment.
This could probably just be a attr_reader, as this vendor data doesnt need to be updated outside of this class
|
|
||
| if total_inventory[item] | ||
| total_inventory[item][:quantity] += quantity | ||
| total_inventory[item][:vendors] << vendor unless total_inventory[item][:vendors].include?(vendor) |
There was a problem hiding this comment.
There may be an easier way to do it! Might be worth asking chatgpt for some refactor tips.
| overstocked_items = [] | ||
|
|
||
| total_inventory.each do |item, info| | ||
| if info[:quantity] > 50 && info[:vendors].length > 1 |
There was a problem hiding this comment.
Nice conditional logic here!
|
|
||
| def potential_revenue | ||
| @inventory.sum do |item, quantity| | ||
| item.price.delete('$').to_f * quantity |
There was a problem hiding this comment.
Cleaning the string down here - nice! Do it in the item class at the beginning :)
| it "exists" do | ||
| expect(@market).to be_instance_of(Market) | ||
| end | ||
|
|
||
| it 'has a name' do | ||
| expect(@market.name).to eq("South Pearl Street Farmers Market") | ||
| end | ||
|
|
||
| it 'has a date' do | ||
| expect(@market.date).to eq("2024/09/16") | ||
| end | ||
|
|
||
| it 'starts with an empty array of vendors' do | ||
| expect(@market.vendors).to eq([]) | ||
| end | ||
| end |
There was a problem hiding this comment.
Functionality from the initialize method can be consolidated into a single test to save time and lines of code.
| def initialize(name) | ||
| @name = name | ||
| @vendors = [] | ||
| @date = Date.today.strftime('%Y/%m/%d') |
| @date = Date.today.strftime('%Y/%m/%d') | ||
| end | ||
|
|
||
| def add_vendor(vendor_object) |
There was a problem hiding this comment.
vendor is probably an appropriate param name here
No description provided.