Devlin Lynch #4
Open
Devlin Lynch #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktu12
reviewed
Sep 17, 2024
| :price | ||
| def initialize(item_info) | ||
| @name = item_info[:name] | ||
| @price = price_to_float(item_info[:price]) |
nicktu12
reviewed
Sep 17, 2024
| @@ -1,3 +1,13 @@ | |||
| class Item | |||
| attr_reader :name, | |||
There was a problem hiding this comment.
Great git commit history!
nicktu12
reviewed
Sep 17, 2024
|
|
||
| def vendors_that_sell(item) | ||
| vendor_list = @vendors.find_all do |vendor| | ||
| vendor.inventory.include?(item) |
There was a problem hiding this comment.
Great use of built in methods
nicktu12
reviewed
Sep 17, 2024
|
|
||
| def total_inventory | ||
| inventory = {} | ||
| @vendors.each do |vendor| |
There was a problem hiding this comment.
There is probably an easier way to write this method! Could be worth asking chatgpt for refactor tips.
nicktu12
reviewed
Sep 17, 2024
|
|
||
| @market.add_vendor(@vendor2) | ||
| @market.add_vendor(@vendor3) | ||
| expect(@market.vendors).to eq([@vendor1,@vendor2,@vendor3]) |
There was a problem hiding this comment.
Love that you expect this works for one vendor, and multiples
nicktu12
reviewed
Sep 17, 2024
| expect(@vendor.inventory.keys).to eq([@item1]) | ||
|
|
||
| @vendor.stock(@item2,20) | ||
| expect(@vendor.inventory.keys).to eq([@item1,@item2]) |
There was a problem hiding this comment.
Stock is tested in isolation - nice!
nicktu12
reviewed
Sep 17, 2024
| item_totals ={} | ||
| @vendors.each do |vendor| | ||
| vendor.inventory.each do |item,quantity| | ||
| if item_totals[item] == nil |
There was a problem hiding this comment.
Great conditional logic checking the state of your hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.