Seth Verrill #5
Open
Seth Verrill #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktu12
reviewed
Sep 17, 2024
| @@ -0,0 +1 @@ | |||
| --format documentation | |||
There was a problem hiding this comment.
Great git commit history!
nicktu12
reviewed
Sep 17, 2024
| @price = float_price(attributes[:price]) | ||
| end | ||
|
|
||
| def float_price(string_price) |
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| list_items.uniq.sort | ||
| end |
There was a problem hiding this comment.
These methods are concise, readable, and follow SRP - nice!
nicktu12
reviewed
Sep 17, 2024
| vendor.inventory.each do |item, quantity| | ||
| inventory_list[item][:quantity] += quantity | ||
| inventory_list[item][:vendors] << vendor | ||
| end |
There was a problem hiding this comment.
Great hash manipulation here!
nicktu12
reviewed
Sep 17, 2024
|
|
||
| def check_stock(item) | ||
| @inventory.has_key?(item) ? @inventory[item] : 0 |
There was a problem hiding this comment.
Ternary operator! My personal favorite.
nicktu12
reviewed
Sep 17, 2024
| expect(@market.overstocked_items).to eq([@item1]) | ||
| end | ||
|
|
||
| xit 'knows when not to sell item' do |
There was a problem hiding this comment.
Skipped tests? If these are failing, try to get them working for some extra practice.
nicktu12
reviewed
Sep 17, 2024
| end | ||
| end | ||
|
|
||
| describe 'date can be any date but will default to current' do |
There was a problem hiding this comment.
Great test / implementation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got through the date in iteration 4.
Tests written for #sell, but not enough time to figure out the code.