Jeremiah Ross #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started working on iteration 4 sate but ran out of time
nicktu12
reviewed
Sep 17, 2024
| @@ -1,3 +1,15 @@ | |||
| class Item | |||
There was a problem hiding this comment.
Next time I would complete all of iteration 3 before moving to iteration 4.
There was a problem hiding this comment.
Great git commit history.
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| def price | ||
| @price_str.delete("$").to_f |
There was a problem hiding this comment.
Nice work cleaning the string!
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| def date | ||
| @date.strftime('%d/%m/%Y') |
There was a problem hiding this comment.
Nicely done! There are other ways to do this, too.
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| it 'can have a date in the past a future' do | ||
| # allow(@market3).to receive(:initialize).and_return(:) |
There was a problem hiding this comment.
Mocks and stubs would have helped with this test!
nicktu12
reviewed
Sep 17, 2024
| expect(@vendor1.inventory).to eq({@peach => 55}) | ||
| end | ||
|
|
||
| it 'can have multiplle items in stock' do |
nicktu12
reviewed
Sep 17, 2024
|
|
||
| RSpec.describe Market do | ||
| before(:each) do | ||
| @peach = Item.new({name: 'Peach', price: "$0.75"}) |
nicktu12
reviewed
Sep 17, 2024
| @vendor1 = Vendor.new("Rocky Mountain Fresh") | ||
| @vendor2 = Vendor.new("Bob's Fish Market") | ||
|
|
||
| @vendor1.stock(@peach, 25) |
There was a problem hiding this comment.
Stocking items might not be a part of your setup, but it works here! Just something to think about - I'd have liked to see the stock method tested in isolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Iteration 1 & 2, did Market #overstocked_items and Market #sorted_item_list for iteration 3
Started date for iteration 4 but ran out of time