Natasha Vasquez #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktu12
reviewed
Sep 17, 2024
|
|
||
| def initialize(item_details) | ||
| @name = item_details[:name] | ||
| @price = item_details[:price] |
There was a problem hiding this comment.
The interaction pattern asks the price string to be cleaned (remove the $) and converted to a float.
nicktu12
reviewed
Sep 17, 2024
| @@ -1,3 +1,10 @@ | |||
| class Item | |||
|
|
|||
| attr_reader :name, :price | |||
|
|
|||
| def initialize(item_details) | |||
There was a problem hiding this comment.
Just item is probably a nice param name here.
nicktu12
reviewed
Sep 17, 2024
|
|
||
|
|
||
| attr_reader :name, :vendors | ||
| attr_accessor :sorted_item_list |
There was a problem hiding this comment.
Does this variable need to be updated outside of this class? Probably not.
nicktu12
reviewed
Sep 17, 2024
| def total_inventory | ||
| inventory = {} | ||
| vendors.each do |vendor| | ||
| vendor.inventory.each do |item, quantity| |
nicktu12
reviewed
Sep 17, 2024
| def overstocked_items | ||
| overstocked = [] | ||
| total_inventory.each do |item, data| | ||
| if data[:vendors].length > 1 && data[:quantity] > 50 |
nicktu12
reviewed
Sep 17, 2024
| @inventory.each do |item, quantity| | ||
| item_price = item.price.delete('$').to_f | ||
| total_revenue += item_price * quantity | ||
| end |
There was a problem hiding this comment.
Indentation here! Really great work with this encapsulated class, though.
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| it 'exists' do | ||
|
|
There was a problem hiding this comment.
Remove whitespace! And pay attention to indentation :)
nicktu12
reviewed
Sep 17, 2024
| end | ||
|
|
||
| it 'can return vendor names, items sold at vendors, and vendor revenue' do | ||
| @vendor1 = Vendor.new("Rocky Mountain Fresh") |
There was a problem hiding this comment.
Some of this setup could have been included in your beforeach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.