Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Double Namespace fix #57

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Nav Double Namespace fix #57

merged 1 commit into from
Oct 31, 2023

Conversation

hilary-luo
Copy link
Contributor

Description

Don't push namespace to nav, it is handled in the nav launch files and was being applied twice.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Launch the simulation including slam, nav and/or localization in the same launch command and include a namespace. Verified that SLAM, Nav and localization all worked, specifically publishing / subscribing to the correct topics (don't have namespace duplicated).

# Run this command
ros2 launch turtlebot4_ignition_bringup turtlebot4_ignition.launch.py nav2:=true slam:=true rviz:=true namespace:=robot1

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@hilary-luo hilary-luo changed the title Nav Namespace fix Nav Double Namespace fix Oct 31, 2023
@hilary-luo hilary-luo merged commit c7a7cab into humble Oct 31, 2023
2 checks passed
@hilary-luo hilary-luo deleted the hl/nav-namespace-patch branch October 31, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants