Code

Add UI for image-attachment "focus"#2620

Code

Merged

connyduck merged 28 commits intotuskyapp:developtuskyapp/Tusky:developfrom mcclure:image-focusmcclure/Tusky:image-focusCopy head branch name to clipboardSep 21, 2022

+358-26

Commits

Commits on Jul 16, 2022

• Attempt-zero implementation of a "focus" feature for image attachments. Choose "Set focus" in the attachment menu, tap once to select focus point (no visual feedback currently), tap "OK". Works in …

  Show description for f3bde24
  mcclure

  committed
  f3bde24

  Copy full SHA for f3bde24

Commits on Jul 17, 2022

• Remove code duplication between 'update description' and 'update focus'

  mcclure

  committed
  613358e

  Copy full SHA for 613358e

Commits on Jul 18, 2022

• Fix ktlint/bitrise failures

  mcclure

  committed
  7d86015

  Copy full SHA for 7d86015

Commits on Jul 22, 2022

• Make updateMediaItem private

  mcclure

  committed
  c283a4c

  Copy full SHA for c283a4c

Commits on Jul 23, 2022

• When focus is set on a post attachment the preview focuses correctly. ProgressImageView now inherits from MediaPreviewImageView.

  mcclure

  committed
  7b3fd74

  Copy full SHA for 7b3fd74

• Replace use of PointF for Focus where focus is represented, fix ktlint

  mcclure

  committed
  02b5e68

  Copy full SHA for 02b5e68

• Substitute 'focus' for 'focus point' in strings

  mcclure

  committed
  84926d9

  Copy full SHA for 84926d9

Commits on Sep 3, 2022

• First attempt draw focus point. Only updates on initial load. Modeled on code from RoundedCorners builtin from Glide

  mcclure

  committed
  a439ec5

  Copy full SHA for a439ec5

• Redraw focus after each tap

  mcclure

  committed
  5e920da

  Copy full SHA for 5e920da

• Dark curtain where focus isn't (now looks like mastosoc)

  mcclure

  committed
  09ab141

  Copy full SHA for 09ab141

• Correct ktlint for FocusDialog

  mcclure

  committed
  8f08b1b

  Copy full SHA for 8f08b1b

Commits on Sep 5, 2022

• draft: switch to overlay for focus indicator

  connyduck

  committed
  d345e62

  Copy full SHA for d345e62

• Draw focus circle, but ImageView and FocusIndicatorView seem to share a single canvas

  mcclure

  committed
  c89cdcf

  Copy full SHA for c89cdcf

• Switch focus circle to path approach

  mcclure

  committed
  3437fa8

  Copy full SHA for 3437fa8

• Correctly scale, save and load focuses. Clamp to visible area. Focus editor looks and feels right

  mcclure

  committed
  480b07b

  Copy full SHA for 480b07b

• ktlint fixes and comments

  mcclure

  committed
  0e6c942

  Copy full SHA for 0e6c942

• Focus indicator drawing should use device-independent pixels

  mcclure

  committed
  f4e4f8b

  Copy full SHA for f4e4f8b

Commits on Sep 18, 2022

• Shrink focus window when it gets unattractively tall (no linting, misbehaves on wide aspect ratio screens)

  mcclure

  committed
  d929b98

  Copy full SHA for d929b98

• Correct max-height behavior for screens in landscape mode

  mcclure

  committed
  dab6381

  Copy full SHA for dab6381

Commits on Sep 19, 2022

• Focus attachment result is are flipped on x axis; fix this

  mcclure

  committed
  af5c995

  Copy full SHA for af5c995

• Correctly thread focus through on scheduled posts, redrafted posts, and drafts (but draft focus is lost on post)

  mcclure

  committed
  829c151

  Copy full SHA for 829c151

• More focus ktlint fixes

  mcclure

  committed
  cde5d5e

  Copy full SHA for cde5d5e

• Fix specific case where a draft is given a focus, then deleted, then posted in that order

  mcclure

  committed
  a93369b

  Copy full SHA for a93369b

• Fix accidental file change in focus PR

  mcclure

  committed
  400683d

  Copy full SHA for 400683d

• Remerge develop with focus PR

  mcclure

  committed
  a81ad1c

  Copy full SHA for a81ad1c

• ktLint fix

  mcclure

  committed
  829a0ed

  Copy full SHA for 829a0ed

Commits on Sep 20, 2022

• Fix property style warnings in focus

  mcclure

  committed
  fc771f3

  Copy full SHA for fc771f3

• Fix remaining style warnings from focus PR

  mcclure

  committed
  33d5745

  Copy full SHA for 33d5745