Implement new policy: The database version number is always even #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase version number is always even (see issue tuskyapp#3999)
connyduck
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posted this as issue #3999 before. The reasoning is personal experiments and forks may add database fields and must bump the database number to do so, but this causes massive merge difficulties when Tusky then inevitably itself bumps the number. To alleviate this, Tusky official should use only even database numbers, so odd versions are available for third party scribbling.
There was little discussion positive or negative in #3999 (one proposal we switch to a date-based number system, which would work but also could be unnecessarily complicated). With PR #4115 we now have to make a decision because that's the first post-proposal PR to bump the database number odd. So, since I see no outright objections, I'd like to implement this.
@connyduck suggested the best way to implement the proposal would be to add a comment to the version number's home in AppDatabase.java.