Conversation
…e error
When no artifacts are found during scanning, `menu_options` remains an
empty array. With `set -euo pipefail` active, expanding `${menu_options[@]}`
on an empty array causes a fatal "unbound variable" error (line 1325).
Add an early-return guard after the spinner stops: if no items were found,
print a friendly "No artifacts found to purge" message and exit cleanly.
Fixes tw93#546
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
@onurtashan LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mo purgecrashes immediately when there are no artifacts to clean:The script uses
set -euo pipefailat the top. When the scan finds nothing,menu_optionsstays empty. Bash throws an "unbound variable" error when you try to expand an empty array withset -uactive — which is exactly what happens at line 1325 when passing${menu_options[@]}toselect_purge_categories.The fix is a simple early return after the spinner stops: if
menu_optionsis empty, show a friendly message and exit cleanly instead of crashing.Fixes #546