Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Tooltip component complete handlers [#37474] #40856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Tooltip component complete handlers [#37474] #40856

wants to merge 1 commit into from

Conversation

yads
Copy link

@yads yads commented Sep 19, 2024 •
edited by julien-deramond
Loading

Description

  • ensure complete handlers for show and hide check if the commponent was disposed

Motivation & Context

  • what can happen is the element can get removed from the DOM and the tooltip would get disposed
  • when the complete handler would run at a later point the component would be disposed and would throw various null related exceptions

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Closes #37474

@yads
fix Tooltip component complete handlers [twbs#37474]
666a3ae 
* ensure `complete` handlers for `show` and `hide` check if the commponent was disposed
* what can happen is the element can get removed from the DOM and the tooltip would get disposed
* when the complete handler would run at a later point the component would be disposed and would throw various null related exceptions
@yads yads requested a review from a team as a code owner September 19, 2024 16:31
@spohlenz spohlenz mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js needs tests v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

function _isWithActiveTrigger in tooltip.js is causing an uncaught error
2 participants
@yads @julien-deramond