Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : add nix-kernel support #96

Merged
merged 3 commits into from
May 27, 2020
Merged

Conversation

GTrunSec
Copy link
Collaborator

Based on https://github.com/corps/nix-kernel

  • test Notebook
    image

Copy link
Contributor

@guaraqe guaraqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can you:

  • Rebase it on top of master, which has an updated Nixpkgs.
  • Add it to the list of kernels to be tested on tests/default.nix.
  • Add a simple example, with a single command in the examples folder.

Comment on lines +8 to +16
python3Packages.buildPythonPackage rec {
pname = "nix-kernel";
version = "0.1";
src = fetchFromGitHub {
owner = "GTrunSec";
repo = "nix-kernel";
rev = "dfa42d0812d508ded99f690ee1a83281d900a3ec";
sha256 = "1lf4rbbxjmq9h6g3wrdzx3v3dn1bndfmiybxiy0sjavgb6lzc8kq";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use a fork of the kernel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use a fork of the kernel?

waiting for merge in. corps/nix-kernel#1

@guaraqe
Copy link
Contributor

guaraqe commented May 27, 2020

You probably merged instead of rebasing, lots of extra commits are showing in the PR.

@GTrunSec GTrunSec force-pushed the nix-kernel branch 2 times, most recently from 17997f7 to 534f07d Compare May 27, 2020 09:25
@GTrunSec GTrunSec requested a review from guaraqe May 27, 2020 09:42
@guaraqe guaraqe merged commit 355dc28 into tweag:master May 27, 2020
@GTrunSec GTrunSec deleted the nix-kernel branch May 27, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants