Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #104

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Dark mode #104

merged 4 commits into from
Sep 11, 2023

Conversation

marlonbaeten
Copy link
Member

Based on the work by @alekangelov, see #102

  • Switched from scss variables to css variables, which makes the implementation of dark mode a bit cleaner.
  • Added button to switch to dark mode (which defaults to the prefers-color-scheme media query setting).
  • Moved the "invert body colors" button close to the body component.
  • Persist both the "dark mode" and "invert body colors" features in local storage.

@marlonbaeten marlonbaeten mentioned this pull request Sep 11, 2023
Closed
@marlonbaeten marlonbaeten merged commit fa5d9df into main Sep 11, 2023
1 check failed
@marlonbaeten marlonbaeten deleted the dark-mode branch September 11, 2023 09:47
@marlonbaeten marlonbaeten mentioned this pull request Sep 11, 2023
Closed
stappersg
stappersg reviewed Sep 11, 2023
View reviewed changes
backend/Cargo.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I'll try my best next time."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stappersg stappersg stappersg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marlonbaeten @stappersg @alekangelov