Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I shouldn't be redirected to Companies when I've disabled Companies object #10064

Open
FelixMalfait opened this issue Feb 6, 2025 · 9 comments · May be fixed by #10461
Open

I shouldn't be redirected to Companies when I've disabled Companies object #10064

FelixMalfait opened this issue Feb 6, 2025 · 9 comments · May be fixed by #10461
Labels
good first issue Good for newcomers

Comments

@FelixMalfait
Copy link
Member

I've just joined a new workspace which had disabled the companies object and yet I was redirected to this view:

Image
@shreyshah-06
Copy link

/assign

@udaysd7897
Copy link

udaysd7897 commented Feb 7, 2025

Hi @FelixMalfait, I would love to contribute but all good first issue are taken
/assign

@iamhvsharma
Copy link

/assign

@FelixMalfait
Copy link
Member Author

Hey all, feel free to raise a PR since this is a short fix we'll merge the first correct one :). Thank you!

@prastoin
Copy link
Contributor

prastoin commented Feb 26, 2025

@FelixMalfait What's even more weird to me is that I can still interact with rows and update them.
Shouldn't the API raise dedicated exceptions when doing CRUD on deactivated object model ? Is that expected ?

@FelixMalfait
Copy link
Member Author

I get your point but I'm not sure yet, because when we have apps they will make the assomptions that those standard objects exist so we might want to keep a behavior where it doesn't break and objects are just hidden

@prastoin
Copy link
Contributor

prastoin commented Feb 26, 2025

Ok I see 🤔
So deactivation is more of hidden/invisible feature.
What is the expected behavior here ?
Should we redirect to the page NOT_FOUND or create a dedicated page with an overlay over the record table ?

@FelixMalfait
Copy link
Member Author

@prastoin to be honest I'm not sure exactly what it will be long-term (just hidden VS deeper deactivation — both are possible paths), that's why I'd suggest to maintain the status quo for now.

For that particular issue, I think the problem is in the logic that decides what is the first page after login.
We could also tackle adding a NOT_FOUND for deactivated objects as a separate issue, but I'm not convinced we should do it yet (again because the vision isn't mature enough so we'd better spend our time on things we're convinced of)

@prastoin
Copy link
Contributor

prastoin commented Feb 26, 2025

Ok makes sense !

For that particular issue, I think the problem is in the logic that decides what is the first page after login.

Unless I'm mistaken I couldn't reproduce this behavior on production. ( Added a new member to the workspaces and wasn't redirected to the company page by default )
Maybe it was due to your inApp navigation history of an other workspace ( sounds weird and would be a different bug )

Were you impersonating a user when this occured ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants