[fix]: Redirect to NOT_FOUND page when landing on unactive Object model

[Paribesh01]

fix: #10064

[github-actions]

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against ea5af8e

[greptile-apps]

PR Summary

Added a check in RecordIndexPage to prevent access to disabled object views, redirecting users to NotFound page when attempting to access inactive objects.

• Reordered conditions in /packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx to check objectMetadataItem?.isActive after ensuring objectMetadataItem is defined to prevent potential undefined behavior
• Added navigation to NotFound page when isActive is false, addressing issue I shouldn't be redirected to Companies when I've disabled Companies object #10064 where users could access disabled company views
• Consider adding a loading state between the undefined check and active check to prevent flash of content

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: Missing return statement after navigation - component will continue executing

Suggested change

	if (!objectMetadataItem?.isActive) {
	navigateApp(AppPath.NotFound);
	}
	if (!objectMetadataItem?.isActive) {
	navigateApp(AppPath.NotFound);
	return null;
	}

[prastoin]

Hello @Paribesh01, thanks for your contribution. You got the main idea !
Left a request regarding some implementation detail

Note: That would be overkill but when entering settings from the company record table page and deactivating the companies, by leaving settings it will redirect to companies page which will redirect to 404. Not a huge plus value here as object model activation and deactivation is IMO not recurrent nor critical

[prastoin]

Remark: Combining optional chaining and bang operator is IMO not very readable.
Here this block will entered if objectMetadataItem is undefined and if isActive is falsy

Also this bypass below if block that will now never occurs anymore ( changing component behavior )

  if (!objectMetadataItem.isActive) {
    navigateApp(AppPath.NotFound);
    return null;
  }
  
  if (
    // First assertion is `never`
    isUndefined(objectMetadataItem) ||
    // Nitpick: might wanna use isUndefined and isEmptyString instead 🤔 
    // Should determine if we want a redirection here
    !isNonEmptyString(contextStoreCurrentViewId)
  ) {
    return null;
  }

[Paribesh01]

@prastoin rather then redirecting to 404 page we can so message like "This company has been deactivated" in the page.

[prastoin]

@prastoin rather then redirecting to 404 page we can so message like "This company has been deactivated."

Yep asked product about the expect behavior here in the related issue #10064 (comment)