fixed #10066, updating formattedInput selectively #10085
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimized field metadata updates in the settings page by implementing selective label-only updates when field names remain unchanged.
- Modified
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsxto handle label-only updates separately from full field updates - Added navigation to object detail page before update execution which could potentially cause UI inconsistencies if update fails
- Implemented optimization to prevent unnecessary field metadata updates when only labels are changed
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx
Show resolved
Hide resolved
|
Hey @FelixMalfait can you review this PR, if you have time. It's only a couple of lines... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating field, current implementation was updating both name and label so in the case where only the formatting of field were to be updated (for eg, instagram -> Instagram) you couldn't because the name would still be the same.
The fix was simply checking if the name was unchanged, and if it was, updating only the label.
fixes: #10066