Feat: API Playground #10376
Feat: API Playground #10376
Conversation
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
…rqx/twenty into feat.api-playground-bounty
| /> | ||
| <StyledSettingsApiPlaygroundCoverImage /> | ||
| <PlaygroundSetupForm /> | ||
| </Section> |
There was a problem hiding this comment.
There are still padding issues.
For example the gap here is 4px:
32px:
16px:
There was a problem hiding this comment.
ah okay I thought you meant in playground. I noticed there were some differences as well which I fixed. Will fix these soon
There was a problem hiding this comment.
Ah yes sorry I should have been more precise, I hadn't noticed the issue on the playground!
packages/twenty-front/src/modules/ui/layout/page/components/DefaultLayout.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/app/components/SettingsRoutes.tsx
Outdated
Show resolved
Hide resolved
| ) !important`}; | ||
| } | ||
| `; | ||
|
|
There was a problem hiding this comment.
Where are we passing the token?
There was a problem hiding this comment.
(Scalar comes with Curl / playground so we want that to be prefilled)
packages/twenty-front/src/modules/settings/playground/components/PlaygroundSetupForm.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/playground/components/PlaygroundSetupForm.tsx
Outdated
Show resolved
Hide resolved
| @@ -355,6 +356,7 @@ | |||
| "name": "twenty", | |||
| "packageManager": "yarn@4.4.0", | |||
| "resolutions": { | |||
| "@codemirror/state": "6.4.1", | |||
There was a problem hiding this comment.
Just for future reference, what was the conflict? Thanks
packages/twenty-front/src/pages/settings/developers/playground/PlaygroundRouter.tsx
Outdated
Show resolved
Hide resolved
| APIs = 'apis', | ||
| PlaygroundRouter = 'playground/:type/:schema', | ||
| DevelopersNewApiKey = 'apis/new', | ||
| DevelopersApiKeyDetail = 'apis/:apiKeyId', |
There was a problem hiding this comment.
Broken link now? Let's keep api-key/new and api-key/:apiKeyId
packages/twenty-front/src/pages/settings/developers/playground/PlaygroundRouter.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/playground/components/PlaygroundPage.tsx
Outdated
Show resolved
Hide resolved
it removes figma border radius
…rqx/twenty into feat.api-playground-bounty
|
@FelixMalfait I just realized my message yesterday night didn't post on github, I'm not sure why. Sorry about that. But thank you for reviewing again. Will address the changes today |
packages/twenty-front/src/modules/settings/playground/components/PlaygroundSetupForm.tsx
Outdated
Show resolved
Hide resolved
|
Also FYI I removed the translations because they are automatically added by a Github Action CI. What you did was correct (lingui extract) but it creates conflicts so our process is to just let the CI do it |
1. move PlaygroundPage to layout/fullscreen/components/FullScreenContainer 2. move useShowFullScreen to layout/fullscreen/hooks/useShowFullScreen
used as key for session storage
/claim #10283