Fix icon load #10777
Closed
Fix icon load #10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses performance issues with @tabler/icons-react v3 integration, specifically fixing Vite's chunking behavior that was creating individual chunks for each icon.
- Removed
AllIcons.tsto prevent unnecessary icon bundling and improve build performance - Added
@tabler/icons-reactto external dependencies inpackages/twenty-front/vite.config.tsto prevent individual icon chunking - Added ESM alias for
@tabler/icons-reactin Vite config to ensure proper module resolution - Commented out lazy loading in
IconsProvider.tsx, but needs validation to ensure icons state is properly initialized
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-ui/src/display/icon/providers/IconsProvider.tsx
Outdated
Show resolved
Hide resolved
Weiko
approved these changes
Mar 11, 2025
prastoin
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We recently upgrade from tabler/react-icons 2 to 3. They have changed the way components are exposed and somehow this was forcing our vite build to create a chunk by icon even if we don't use them
Fix
https://www.reddit.com/r/reactjs/comments/1g3tsiy/trouble_with_vite_tablericons_5600_requests/