Skip to content

Fix tabler icons load #10782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 11, 2025
Merged

Fix tabler icons load #10782

merged 8 commits into from
Mar 11, 2025

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Mar 11, 2025 •
edited
Loading

greptile-apps[bot]
greptile-apps bot reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR downgrades the @tabler/icons-react package from v3.31.0 to v3.18.0 to address icon loading issues in the Twenty application.

  • Downgrade in /packages/twenty-front/package.json appears to be a significant version rollback, suggesting potential compatibility issues with newer versions
  • Given the usage of Tabler icons in components like /packages/twenty-website/src/app/_components/ui/icons/index.ts, thorough testing of icon rendering across the application is recommended
  • Consider documenting the specific icon loading issues that necessitated this downgrade for future reference

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

prastoin
prastoin approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@prastoin prastoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

@charlesBochet charlesBochet merged commit d9817d6 into main Mar 11, 2025
26 checks passed
@charlesBochet charlesBochet deleted the fix-icons-2 branch March 11, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@prastoin prastoin prastoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesBochet @prastoin