[Fix] Class validator native isSemver does not handle v-prefix

[prastoin]

Introduction

Under the hood class-validator isSemver uses https://github.com/validatorjs/validator.js/blob/master/src/lib/isSemVer.js which does not cover all semVer use cases

Even tho

Had a discussion with @charles was about to store in db ws version as vx.y.z. We felt like we wanted it to be stored as x.y.z, in my opinion APP_VERSION should reflect the tag used to be build the instance and not be updated
But we could extract only x.y.z from it at runtime

Also handling the v extraction in CD is IMO not the most reliable

Env var logging refactor

Now not stopping on first error log

Successfully compiled: 2128 files with swc (185.34ms)
Watching for file changes.
[Nest] 52686  - 03/14/2025, 6:28:33 PM   ERROR PG_DATABASE_URL should not be null or undefined
PG_DATABASE_URL must be a URL address
[Nest] 52686  - 03/14/2025, 6:28:33 PM   ERROR APP_VERSION must be a valid semantic version (e.g., 1.0.0)

/Users/paulrastoin/ws/twenty/packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts:1019
    throw new Error("Environment variables validation failed")
          ^
Error: Environment variables validation failed
    at Object.validate (/Users/paulrastoin/ws/twenty/packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts:1019:11)
    at Function.forRoot (/Users/paulrastoin/ws/twenty/node_modules/@nestjs/config/dist/config.module.js:67:45)
    at Object.<anonymous> (/Users/paulrastoin/ws/twenty/packages/twenty-server/src/engine/core-modules/environment/environment.module.ts:11:18)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:121:18)
    at Object.<anonymous> (/Users/paulrastoin/ws/twenty/packages/twenty-server/dist/src/database/typeorm/typeorm.module.js:14:28)

[greptile-apps]

PR Summary

This PR improves semantic version validation by replacing the built-in validator with a custom implementation that better handles version strings and enhances environment variable error reporting.

• Added IsTwentySemVerValidator in /packages/twenty-server/src/engine/core-modules/environment/decorators/is-twenty-semver.decorator.ts using semver package for more robust version validation
• Modified environment variable validation in environment-variables.ts to show all validation errors instead of stopping at first error
• Improved error messages to include examples (e.g., "must be a valid semantic version (e.g., 1.0.0)")
• Removed dependency on validatorjs in favor of more reliable semver package

_{2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile}