Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opportunity specific code on Kanban #11000

Merged
merged 14 commits into from
Mar 18, 2025
Merged

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Mar 18, 2025

In this PR:

  • clean board from opportunity specific logic
  • remove in place creation in board
  • trigger creation in right drawer instead

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes opportunity-specific code from the Kanban board implementation, making it more generic and reusable across different object types.

  • Removed RecordBoardColumnNewOpportunity.tsx component and replaced with generic record creation approach
  • Simplified useAddNewCard hook by removing company-related logic and SingleRecordPicker dependencies
  • Removed isOpportunity field from NewCard type in recordBoardNewRecordByColumnIdComponentFamilyState.ts
  • Cleaned up unused opportunity-related imports and checks in RecordBoardColumnCardsContainer.tsx
  • Note: Several components still import unused opportunity-related hooks (useIsOpportunitiesCompanyFieldDisabled) that should be removed

8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -63,7 +57,6 @@ export const useAddNewCard = ({
columnId: columnDefinitionId,
isCreating: true,
position,
isOpportunity,
company: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: company field is still present in the state but company-related functionality has been removed. Consider removing this field.

@charlesBochet charlesBochet merged commit a4bd00a into main Mar 18, 2025
29 checks passed
@charlesBochet charlesBochet deleted the fix-kunai-issues branch March 18, 2025 22:54
Copy link

sentry-io bot commented Mar 23, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Object metadata item "what" cannot be found in an array of 39 elements /object/what/hah View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants