-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove opportunity specific code on Kanban #11000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR removes opportunity-specific code from the Kanban board implementation, making it more generic and reusable across different object types.
- Removed
RecordBoardColumnNewOpportunity.tsx
component and replaced with generic record creation approach - Simplified
useAddNewCard
hook by removing company-related logic and SingleRecordPicker dependencies - Removed
isOpportunity
field fromNewCard
type inrecordBoardNewRecordByColumnIdComponentFamilyState.ts
- Cleaned up unused opportunity-related imports and checks in
RecordBoardColumnCardsContainer.tsx
- Note: Several components still import unused opportunity-related hooks (
useIsOpportunitiesCompanyFieldDisabled
) that should be removed
8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -63,7 +57,6 @@ export const useAddNewCard = ({ | |||
columnId: columnDefinitionId, | |||
isCreating: true, | |||
position, | |||
isOpportunity, | |||
company: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: company field is still present in the state but company-related functionality has been removed. Consider removing this field.
79ea1cc
to
ad3f01c
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
In this PR: