feature #4105 Deprecate the second argument of CallExpression::compil…

…eArguments (fabpot) This PR was merged into the 3.x branch. Discussion ---------- Deprecate the second argument of CallExpression::compileArguments Commits ------- 71d6c82 Deprecate CallExpression::compileArguments
twigphp · Jun 18, 2024 · ca39534 · ca39534
2 parents ab071ef + 71d6c82
commit ca39534
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,6 @@
-# 3.10.4 (2024-XX-XX)
+# 3.11.0 (2024-XX-XX)
 
- * n/a
+ * Deprecate the second argument of `Twig\Node\Expression\CallExpression::compileArguments()`
 
 # 3.10.3 (2024-05-16)
 

diff --git a/doc/deprecated.rst b/doc/deprecated.rst
@@ -32,6 +32,13 @@ Extensions
   After:
   $twig->getRuntime(EscaperRuntime::class)->METHOD();
 
+Nodes
+-----
+
+* The second argument of the
+  ``Twig\Node\Expression\CallExpression::compileArguments()`` method is
+  deprecated.
+
 Node Visitors
 -------------
 

diff --git a/src/Node/Expression/CallExpression.php b/src/Node/Expression/CallExpression.php
@@ -57,6 +57,10 @@ protected function compileCallable(Compiler $compiler)
 
     protected function compileArguments(Compiler $compiler, $isArray = false): void
     {
+        if (func_num_args() >= 2) {
+            trigger_deprecation('twig/twig', '3.11', 'Passing a second argument to "%s()" is deprecated.', __METHOD__);
+        }
+
         $compiler->raw($isArray ? '[' : '(');
 
         $first = true;